Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove iltorb dep, build for node v22.9.0 #2273

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Oct 10, 2024

bundlesize->ilortb->node-gyp was throwing errors when trying to build using nodev22

this pr fixes build for node v22 by removing dependency on bundlesize, which was only a dev-dep.

spawned due to #2259 (review)

This PR also fixes a bug with the npm script analyze not functioning properly

We can now see that the bundle size is ~23MB:

image

@SgtPooki SgtPooki changed the title fix: build for node v22.9.0 fix: remove iltorb dep, build for node v22.9.0 Nov 7, 2024
Copy link
Member Author

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review

@SgtPooki SgtPooki merged commit 9ba4559 into main Nov 7, 2024
22 checks passed
@SgtPooki SgtPooki deleted the fix/remove-iltorb branch November 7, 2024 18:23
ipfs-gui-bot pushed a commit that referenced this pull request Nov 7, 2024
## [4.4.0](v4.3.3...v4.4.0) (2024-11-07)

 CID `bafybeibkirkltohusogcco46jcw7khtgjf5nwphuvufjssr5pvhsuol5uy`

 ---

### Features

* use [email protected] ([#2283](#2283)) ([437b8fe](437b8fe)), closes [#2259](#2259)

### Bug Fixes

* normalize catch-all listeners to loopback ([#2287](#2287)) ([edf14c6](edf14c6)), closes [#1821](#1821)
* remove iltorb dep, build for node v22.9.0 ([#2273](#2273)) ([9ba4559](9ba4559))

### Trivial Changes

* move enum.js to lib folder ([#2285](#2285)) ([682de0b](682de0b))
* pull new translations ([#2279](#2279)) ([8205d12](8205d12))
@ipfs-gui-bot
Copy link
Collaborator

🎉 This PR is included in version 4.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants