feat!: remove deprecated /api/v0 #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Thank you for cleaning this up. It makes sense, removal from KUBO_RPC_URL reduces confusion, but there will be old code in the wild that uses /api/v0/resolve etc that will break. People don't follow release notes, deprecations, will learn about this from errors.
We should do basic courtesy of returning meaningful error for all /api/v0 requests, allowing them to fix their app without debugging what happened.
Mind addressing below comment? Other than that, lgtm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've just removed it from Kubo, so I think it's a good idea to clean this up here too: ipfs/kubo#10352