feat: shared cache for manual peering #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacdias
force-pushed
the
feat/accelerated-dht-flag
branch
from
5acdfbb to
2a02d63
Compare
hacdias
force-pushed
the
feat/shared-cache
branch
2 times, most recently
from
c7e3924 to
9f64e24
Compare
hacdias
force-pushed
the
feat/shared-cache
branch
2 times, most recently
from
8e9ddf7 to
ee70d5d
Compare
hacdias
commented
Apr 8, 2024
Comment on lines
-324
to
365
| bswap := bsclient.New(bsctx, bn, blkst, | ||
| bswap := bitswap.New(bsctx, bn, blkst, | ||
| // --- Client Options | ||
| // default is 1 minute to search for a random live-want (1 | ||
| // CID). I think we want to search for random live-wants more | ||
| // often although probably it overlaps with general | ||
| // rebroadcasts. | ||
| bsclient.RebroadcastDelay(delay.Fixed(10*time.Second)), | ||
| bitswap.RebroadcastDelay(delay.Fixed(10*time.Second)), | ||
| // ProviderSearchDelay: default is 1 second. | ||
| bsclient.ProviderSearchDelay(time.Second), | ||
| bsclient.WithoutDuplicatedBlockStats(), | ||
| bitswap.ProviderSearchDelay(time.Second), | ||
| bitswap.WithoutDuplicatedBlockStats(), | ||
|
|
||
| // ---- Server Options | ||
| bitswap.WithPeerBlockRequestFilter(peerBlockRequestFilter), | ||
| bitswap.ProvideEnabled(provideEnabled), | ||
| ) |
There was a problem hiding this comment.
Another option here would be to create only a client with bsclient.New if peering cache is disabled. But to me it seemed that a peer block request filter that always returns false should do the same thing. Depends a bit more on the internals of the bitswap package.
There was a problem hiding this comment.
This might be ok, but we should measure our libp2p egress bandwidth to hosts we don't control to see to validate that this is true.
hacdias
commented
Apr 8, 2024
| @@ -0,0 +1,94 @@ | |||
| package main | |||
There was a problem hiding this comment.
ℹ️ Just moved some shared test utilities to this file.
lidel
requested changes
Apr 9, 2024
hacdias
force-pushed
the
feat/shared-cache
branch
from
ee70d5d to
e317e2d
Compare
hacdias
force-pushed
the
feat/shared-cache
branch
2 times, most recently
from
f1ed448 to
c011630
Compare
hacdias
force-pushed
the
feat/shared-cache
branch
2 times, most recently
from
7d7a783 to
e259336
Compare
lidel
changed the title
lidel
force-pushed
the
feat/shared-cache
branch
2 times, most recently
from
0558af0 to
ae6d7cc
Compare
lidel
approved these changes
Apr 20, 2024
There was a problem hiding this comment.
lgtm, pushed small cosmetics, should be good to ship as v1.1.0 (but see #102 (review) first)
also, print version as the very first thing
hacdias
force-pushed
the
feat/shared-cache
branch
from
ae6d7cc to
f6bd4ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC #109 #27