Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release v1.5.0 #158

Merged
merged 5 commits into from
Aug 7, 2024
Merged

chore: release v1.5.0 #158

merged 5 commits into from
Aug 7, 2024

Conversation

lidel
Copy link
Member

@lidel lidel commented Aug 7, 2024

This PR is bare minimum to be able to bump dependencies with various upstream bugfixes:

setup_bitswap.go Outdated
Comment on lines 86 to 88
func (*noopPeerLedger) Wants(p peer.ID, e wl.Entry) bool {
return false
}
Copy link
Member Author

@lidel lidel Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old rainbow had this noopPeerLogger implementation and i had to start returning a bool after updating boxo here.

Seems that hardcoding false here causes panic in
https://github.com/ipfs/boxo/blob/v0.22.0/bitswap/server/internal/decision/engine.go#L876
panic: runtime error: index out of range [0] with length 0
go test log here

Copy link
Member Author

@lidel lidel Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed noopPeerLedger.

Rationale:

  • After looking at things bit deeper I realized WithPeerBlockRequestFilter is enough and custom PeerLedger does not help us with anything, and after overflow fixes in boxo 0.22 only causes problems (because we do want PeerLedger that correctly tracks wants that are not filtered by WithPeerBlockRequestFilter).
  • Low risk since RAINBOW_SEED_PEERING is false by default, and it is marked as experimental feature (that we decided to not use in our infra).

lidel added 3 commits August 8, 2024 01:03
boxo v0.22.0 changed the way ledger interacts with overflow
and this noop no longer works

WithPeerBlockRequestFilter should be enough for now
@lidel lidel force-pushed the chore/go-libp2p-v0361 branch from 164c3b4 to 7ceaa42 Compare August 7, 2024 23:28
@lidel lidel changed the title chore: go-libp2p v0.36.1 boxo 0.22.0 chore: release v1.5.0 (go-libp2p v0.36.1 boxo v0.22.0) Aug 7, 2024
Copy link

github-actions bot commented Aug 7, 2024

Suggested version: 1.5.0

Comparing to: v1.4.0 (diff)

Changes in configuration file(s):

diff --git a/go.mod b/go.mod
index 58381d7..aa40d01 100644
--- a/go.mod
+++ b/go.mod
@@ -20,6 +20,7 @@ require (
 	github.com/ipfs/go-log/v2 v2.5.1
 	github.com/ipfs/go-metrics-interface v0.0.1
 	github.com/ipfs/go-metrics-prometheus v0.0.2
+	github.com/ipfs/go-test v0.0.2
 	github.com/ipfs/go-unixfsnode v1.9.0
 	github.com/ipld/go-codec-dagpb v1.6.0
 	github.com/libp2p/go-libp2p v0.35.1

gorelease says:

# diagnostics
required module github.com/microcosm-cc/[email protected] retracted by module author: Retract older versions as only latest is to be depended upon

# summary
Suggested version: v1.5.0

gocompat says:

HEAD is now at 0a58582 chore: release v1.4.0 (#153)
Previous HEAD position was 0a58582 chore: release v1.4.0 (#153)
Switched to branch 'main'
Your branch is up to date with 'origin/main'.

Cutting a Release (and modifying non-markdown files)

This PR is modifying both version.json and non-markdown files.
The Release Checker is not able to analyse files that are not checked in to main. This might cause the above analysis to be inaccurate.
Please consider performing all the code changes in a separate PR before cutting the release.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

@lidel lidel changed the title chore: release v1.5.0 (go-libp2p v0.36.1 boxo v0.22.0) chore: release v1.5.0 Aug 7, 2024
@lidel lidel marked this pull request as ready for review August 7, 2024 23:54
@lidel lidel merged commit 471f095 into main Aug 7, 2024
21 checks passed
@lidel lidel deleted the chore/go-libp2p-v0361 branch August 7, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant