-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add resource manager for separate DHT libp2p host #54
Conversation
Have we established that running 2 hosts is better? I keep forgetting that there are 2. We should settle on one or 2. |
d1d1827
to
9ac2e2b
Compare
@@ -15,6 +16,39 @@ import ( | |||
|
|||
var infiniteResourceLimits = rcmgr.InfiniteLimits.ToPartialLimitConfig().System | |||
|
|||
func makeResourceMgrs(maxMemory uint64, maxFD int, connMgrHighWater int, separateDHT bool) (bitswapHost, dhtHost network.ResourceManager, err error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes here might be overkill and is pretty guesstimated, just wanted something other than disabling the resource manager for people to test with.
Recommendations appreciated 🙏
2024-01-05 conversation:
Wny this matters: If we don't see any errors here, then the priority of this goes down. Note that we'll only see the errors closer to node startup. Next step: Get @aschmahmann access to logs and a record of what commit was deployed when. |
c512e2e
to
32d7e58
Compare
32d7e58
to
5eae981
Compare
Seems like we need a separate resource manager for the DHT host if it's separate. For now I just reused the limits, but that's obviously not right since that would put the default memory usage at
0.85 * 2
of total memory and0.5 *2
of total FDs.Some notes:
Thoughts?