-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipvs: toa enhancements #928
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ywc689
commented
Dec 11, 2023
•
edited
Loading
edited
- Do not insert toa data in syn packets any more.
- Compact tcp option space or remove some options when inserting toa data failed and then try again.
- Emit a warning log for audit when toa insertion failed finally.
ywc689
force-pushed
the
toa-enhancement
branch
from
December 11, 2023 13:00
74399d8
to
0b8d1a4
Compare
ywc689
added
the
pr/to-review-codes
review codes line by line and check if problem exists.
label
Dec 11, 2023
ywc689
force-pushed
the
toa-enhancement
branch
from
December 12, 2023 02:09
0b8d1a4
to
b4043dc
Compare
ytwang0320
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approve +1
ywc689
added
pr/codes-reviewed-ok
code review passed and no problem found
pr/accepted
the pr passed all review stages and await to be merged
and removed
pr/to-review-codes
review codes line by line and check if problem exists.
labels
Dec 12, 2023
donghaobo
reviewed
Dec 12, 2023
donghaobo
reviewed
Dec 13, 2023
ywc689
force-pushed
the
toa-enhancement
branch
from
December 13, 2023 12:15
f238fe6
to
e8a3a97
Compare
ywc689
force-pushed
the
toa-enhancement
branch
3 times, most recently
from
December 14, 2023 08:30
7b09a7f
to
c751688
Compare
1. Do not insert toa data in syn packets any more. 2. Compact tcp option space or remove some options when inserting toa data failed and then try again. 3. Emit a warning log for audit when toa insertion failed finally. Signed-off-by: ywc689 <[email protected]>
Signed-off-by: ywc689 <[email protected]>
ywc689
force-pushed
the
toa-enhancement
branch
from
December 14, 2023 10:53
c751688
to
58a0e75
Compare
cfc4n
reviewed
Dec 15, 2023
donghaobo
reviewed
Dec 15, 2023
donghaobo
reviewed
Dec 15, 2023
donghaobo
reviewed
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr/accepted
the pr passed all review stages and await to be merged
pr/codes-reviewed-ok
code review passed and no problem found
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.