Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sasl-3.1: recommend against logging AUTHENTICATE arguments #522

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion extensions/sasl-3.1.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,11 @@ aborted. Clients SHOULD be prepared for timeouts at all times during the SASL
authentication.

There are two forms of the AUTHENTICATE command: initial client message and
later messages.
later messages. Since there is no way besides ordering to make the difference
between these two forms, servers SHOULD avoid logging or formatting error
messages with the arguments of the AUTHENTICATE command to prevent secrets from
being leaked (e.g. in case a client doesn't wait for the server's initial empty
challenge before sending credentials).

The initial client message specifies the SASL mechanism to be used. (When this
is received, the IRCD will attempt to establish an association with a SASL
Expand Down