Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename shark-turbine -> iree.turbine #197

Merged
merged 7 commits into from
Oct 5, 2024
Merged

Conversation

Hardcode84
Copy link
Contributor

@Hardcode84 Hardcode84 commented Oct 5, 2024

  • Move files from files from shark-turbine to iree/turbine.
  • Update imports
  • Update setup.py
  • Make backward redirect shark-turbine -> iree.turbine (do we need this?)

Progress on #28

Signed-off-by: Ivan Butygin <[email protected]>
Signed-off-by: Ivan Butygin <[email protected]>
Signed-off-by: Ivan Butygin <[email protected]>
Signed-off-by: Ivan Butygin <[email protected]>
Signed-off-by: Ivan Butygin <[email protected]>
Signed-off-by: Ivan Butygin <[email protected]>
@Hardcode84 Hardcode84 changed the title Rename Rename shark-turbine -> iree.turbine Oct 5, 2024
@Hardcode84 Hardcode84 marked this pull request as ready for review October 5, 2024 16:12
Signed-off-by: Ivan Butygin <[email protected]>
@Hardcode84 Hardcode84 merged commit b0ef345 into iree-org:main Oct 5, 2024
8 checks passed
@Hardcode84 Hardcode84 deleted the rename branch October 5, 2024 16:30
saienduri added a commit to nod-ai/iree-kernel-benchmark that referenced this pull request Oct 6, 2024
This commit adapts to the recent changes made to the packaging naming in
the iree-org/iree-turbine repo:
iree-org/iree-turbine#197
saienduri added a commit to nod-ai/shark-ai that referenced this pull request Oct 7, 2024
This commit makes the necessary changes to adapt to the new iree-turbine
namespace.
Related PR: iree-org/iree-turbine#197

Signed-off-by: saienduri <[email protected]>
@sogartar
Copy link
Contributor

sogartar commented Oct 7, 2024

This change does not allow for patterns like

from shark_turbine.aot import (
    ParameterArchiveBuilder,
)
ImportError: cannot import name 'ParameterArchiveBuilder' from 'shark_turbine.aot' (unknown location)

These are present in sharktank.

@bhbruce
Copy link

bhbruce commented Oct 8, 2024

Hi @Hardcode84
Will you modify the name and path in SHARK-ModelDev?

stellaraccident pushed a commit that referenced this pull request Oct 13, 2024
* Move files from files from `shark-turbine` to `iree/turbine`.
* Update imports
* Update `setup.py`
* Make backward redirect `shark-turbine` -> `iree.turbine` (do we need
this?)

Progress on #28

---------

Signed-off-by: Ivan Butygin <[email protected]>
Hardcode84 added a commit to Hardcode84/iree-turbine that referenced this pull request Oct 14, 2024
* Move files from files from `shark-turbine` to `iree/turbine`.
* Update imports
* Update `setup.py`
* Make backward redirect `shark-turbine` -> `iree.turbine` (do we need
this?)

Progress on iree-org#28

---------

Signed-off-by: Ivan Butygin <[email protected]>
saienduri pushed a commit that referenced this pull request Oct 28, 2024
* Move files from files from `shark-turbine` to `iree/turbine`.
* Update imports
* Update `setup.py`
* Make backward redirect `shark-turbine` -> `iree.turbine` (do we need
this?)

Progress on #28

---------

Signed-off-by: Ivan Butygin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants