pythongh-109889: fix redundant NOP detection to look past NOPs with n…

…o lineno when looking for the next instruction's lineno
iritkatriel · Sep 27, 2023 · 10cc46f · 10cc46f
1 parent cc54bcf
commit 10cc46f
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/Lib/test/test_compile.py b/Lib/test/test_compile.py
@@ -1278,6 +1278,11 @@ def f(x):
             while x:
                 0 if 1 else 0
 
+    def test_remove_redundant_nop_edge_case(self):
+        # See gh-109889
+        def f():
+            a if (1 if b else c) else d
+
 @requires_debug_ranges()
 class TestSourcePositions(unittest.TestCase):
     # Ensure that compiled code snippets have correct line and column numbers

diff --git a/Python/flowgraph.c b/Python/flowgraph.c
@@ -1017,7 +1017,17 @@ remove_redundant_nops(basicblock *bb) {
                 }
                 /* or if last instruction in BB and next BB has same line number */
                 if (next) {
-                    if (lineno == next->b_instr[0].i_loc.lineno) {
+                    location next_loc = NO_LOCATION;
+                    for (int j=0; j < next->b_iused; j++) {
+                        cfg_instr *instr = &next->b_instr[j];
+                        if (instr->i_opcode == NOP && instr->i_loc.lineno == NO_LOCATION.lineno) {
+                            /* Skip over NOPs without location because they will be removed */
+                            continue;
+                        }
+                        next_loc = instr->i_loc;
+                        break;
+                    }
+                    if (lineno == next_loc.lineno) {
                         continue;
                     }
                 }