STAGING -> MASTER #4542
Merged
STAGING -> MASTER #4542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adds binary build that is independent of caxa package and is signable * rebuild windows binary to test * fix bug in windows node command * try to run in bash * finalized version of workflow, switches back to being run on publish only * adds signing capabilities for windows/mac * fix bug in paths for binary * finalizing uncomment/comments
* displaying combined notes in transaction result * removing sentence summary * using currency utils to render table iron amount
* subtracting the fee amount from the transaction amount * changing variable name * adding raw fee to params * updating comment * removing ternary for params.fee
* adding trusted dealer key package napi struct * moving TrustedDealerKeyPackages to keypackages new file * resetging librs * adding license header * running cargo fmt linter
* ironfish frost with reddsa export * reverting rand core depdency downgrade
* feat: minimize unsigned spend builder requirements * cargo clippy
This allows you to extend Config with custom extended config types. It does now require you to pass the extended defeults into the Config() constructor even if you are not extending it for type reasons. This makes the Config API slightly more burdensome to use but it's a small price to pay.
* adding hex_to_vec_bytes * hex_to_vec_bytes tests * removing unwrap from test * adding check for even length hex array * test for even length hex * marking unused variable * removing variable name for unused variable
* adding frost signature assignment * moved sign_frost to unsignedMintDescription * adding frost sign test for mints * function name change * running linter * removing return type from add signature functions * linting * adding description return type * removing extra key in test
* WIP removes spender_key and public_key_randomness from ProposedTransaction when signing transactions with FROST we will not have a full, valid SaplingKey to pass as the 'spender_key'. FROST will also require that public key randomness is shared between signers with randomized parameters used as an input to signing. spender_key is only used when posting ProposedTransactions, so these changes remove it from the struct and instead pass it as an input to each of the post functions public_key_randomness is only used in the context of _partial_post, so these changes remove public_key_randomness from the struct and initialize a randomized public address from randomness only when needed * fixes tests outdated usage of NativeTransaction constructor, post * passes reference to SaplingKey to post methods avoids excessive copying to the stack * restores public_key_randomness to ProposedTransaction * fixes tests * fixes benches * fixes lint
* add build() to ProposedTransaction to build UnsignedTransaction * add build method to proposed transaction
* proof serializable trait: * initial serialize tests * adding tests for invalid ak nsk * removing extra test
Bump CLI to 1.16.0 Bump SDK to 1.16.0 Bump rust to 1.13.0
mat-if
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.