Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging to master v2.4.0 #5071

Merged
merged 95 commits into from
Jun 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
95 commits
Select commit Hold shift + click to select a range
96fdf4a
supports viewing posted transactions on cli (#4936)
hughy Apr 29, 2024
fbf99a7
Add minorToMajor conversion function (#4938)
danield9tqh Apr 30, 2024
1c7721c
Remove backup and restore CLI commands (#4939)
dguenther Apr 30, 2024
82af315
Only log transaction flushing if non-zero (#4940)
dguenther May 3, 2024
3151a19
Upgrade node-datachannel to 0.8.0 (#4941)
dguenther May 6, 2024
e500ce8
Remove unused eventLoopResolve in Wallet (#4946)
dguenther May 7, 2024
1b002fe
Remove use of deprecated block.previous in RemoteChainProcessor (#4945)
dguenther May 7, 2024
fa6fc86
Fix deprecation and wrong runners in build-ironfish-rust-nodejs.yml (…
dguenther May 8, 2024
2584229
Update Checkout action in CI to v4 (#4947)
dguenther May 8, 2024
4ef3e46
Validates public address is accurate for corresponding keys on import…
patnir May 8, 2024
1e14533
Remove old migration code (#4954)
NullSoldier May 10, 2024
6bd255f
Feat: support chain/getBlocks (#4942)
hairtail May 10, 2024
03ccb4e
Change account not to have 1 object constructor (#4956)
NullSoldier May 13, 2024
62b7e71
Fix scan state TODO in wallet code (#4960)
dguenther May 14, 2024
2eda956
Separate out block getter from RPC serialization (#4963)
NullSoldier May 16, 2024
aa4e237
Asset balance deltas now display in the correct denomination (#4966)
mat-if May 20, 2024
b5bbb4e
adds raw transaction flag to combine notes (#4915)
patnir May 20, 2024
088b533
Update description of wallet:rescan (#4957)
dguenther May 21, 2024
ca60831
determines raw tx sender from tx fields (#4970)
hughy May 21, 2024
a1eb8e5
Move wallet/account/encoder to wallet/exporter (#4971)
NullSoldier May 21, 2024
c03525d
Move multisig key encoder into database (#4972)
NullSoldier May 22, 2024
8400588
Remove AccountValue from account importer/exporter (#4973)
NullSoldier May 22, 2024
cb912d3
sorts accounts by name in 'wallet:transaction:view' (#4974)
hughy May 22, 2024
dc18b63
Give bech32 encoder it's own multisig encoder (#4976)
NullSoldier May 22, 2024
eb72059
Moved multisig importing into wallet/exporter (#4977)
NullSoldier May 22, 2024
3c7fe43
Fix migration 031 to use proper multisig encoder (#4978)
NullSoldier May 23, 2024
955310f
defaults cli tables to no-truncate (#4979)
hughy May 23, 2024
2a4283f
Add startScanning and stopScanning RPC and CLI commands (#4943)
dguenther May 23, 2024
2c17136
Scan wallet accounts from earliest account head first (#4964)
dguenther May 23, 2024
7920d49
don't watch expired transactions (#4968)
patnir May 28, 2024
8a0a9c6
Add wallet/resetAccount RPC (#4985)
dguenther May 28, 2024
82b9943
Remove unused tar util from CLI (#4987)
dguenther May 28, 2024
64ed9a1
Prompt for expiration sequence when creating raw or unsigned transact…
dguenther May 29, 2024
2c0d518
Add wallet/setAccountHead RPC (#4951)
dguenther May 30, 2024
61d5241
adds chainport metadata encoder/ decoder (#5000)
patnir Jun 3, 2024
2f43a77
Rahul/ifl 2637 add chainport config (#5001)
patnir Jun 3, 2024
d989069
adds chainport requests interface and types (#5002)
patnir Jun 3, 2024
f7944ab
supports pruning expired tx for one account (#4999)
hughy Jun 3, 2024
0c3366d
Rahul/ifl 2638 chainport add utils (#5007)
patnir Jun 4, 2024
a645e2a
supports combining notes for custom assets (#5005)
hughy Jun 4, 2024
dc671e6
Adds ability to filter assets in cli utils (#5009)
patnir Jun 4, 2024
fa142d5
Allow wallet to take createdAt for new account (#5003)
danield9tqh Jun 5, 2024
1c11b76
Show verified checkmark when selecting asset and sort by verified (#4…
danield9tqh Jun 5, 2024
2e71269
Change setAccountHead to take blocks instead of transactions (#5004)
dguenther Jun 5, 2024
eaef657
adds chainport transaction summary util (#5011)
patnir Jun 5, 2024
9d80615
detect bridge transactions in wallet:transactions command (#5012)
patnir Jun 5, 2024
9cd963f
Adds ability to detect chainport transactions in wallet:transaction (…
patnir Jun 6, 2024
1613296
Move wallet scanning code into WalletScanner (#4983)
NullSoldier Jun 6, 2024
d541de8
Return latest account head in node status (#5017)
NullSoldier Jun 6, 2024
f5035de
Organize RPC namespace folders (#5019)
NullSoldier Jun 6, 2024
584d5ca
Adds wallet:chainport:send CLI command (#5015)
patnir Jun 6, 2024
b5825c5
Remove Wallet.getLatestHeadHash() (#5018)
NullSoldier Jun 6, 2024
d038fda
adds feerate to flags of chainport CLI command (#5021)
patnir Jun 6, 2024
730fb56
Delete WalletBlockHeader and WalletTransaction (#5020)
NullSoldier Jun 6, 2024
6dbed7e
renames transaction:add to transaction:import (#5016)
hughy Jun 6, 2024
db88f4f
adds unspent notes count to wallet balance rpc, cli (#4998)
hughy Jun 6, 2024
506b6ab
regenerate fixtures for performance tests (#5023)
patnir Jun 7, 2024
5c1b709
adds account flag to wallet commands (#4994)
hughy Jun 7, 2024
520c310
oclif 1.23.1 -> 3.27.0 (#5024)
mat-if Jun 7, 2024
26812d7
upgrade oclif cli tool (#5026)
mat-if Jun 7, 2024
7fb8b45
Update comment on setAccountHead blocks field (#5025)
dguenther Jun 8, 2024
09eeb50
Remove RemoteChainProcessor calculating noteIndex (#5027)
NullSoldier Jun 10, 2024
cb35246
Remove version account version default (#4955)
NullSoldier Jun 10, 2024
8c66073
Removes the ability to import/export AccountImport (#5032)
NullSoldier Jun 11, 2024
8565bfd
Remove unnecessary trims from CLI commands (#5031)
mat-if Jun 11, 2024
d412ed1
Rename function to be more clear (#5035)
NullSoldier Jun 11, 2024
f32ba97
Remove usage of chain.getBlockTransactions (#5028)
NullSoldier Jun 11, 2024
c0f9736
Move usage of RpcAccountImport to exporter system (#5034)
NullSoldier Jun 12, 2024
9427dbc
Normalize arg destructuring and remove a few extra `as` casts (#5033)
mat-if Jun 12, 2024
5a37b12
Remove unused `parseBoolean` util function from CLI (#5029)
mat-if Jun 12, 2024
396b057
Remove the `fishHashContext` argument from `sdk.node()`
andiflabs Jun 12, 2024
bbc9955
Automatically start the worker pool if a job is submitted (#5039)
andiflabs Jun 13, 2024
f0326d0
Separate out account decoding from encrypting (#5038)
NullSoldier Jun 13, 2024
3c00d45
avoids resetting account birthday (#5036)
hughy Jun 13, 2024
fd3953d
Add error message for VerifyError (#5045)
mat-if Jun 14, 2024
86c8b9a
update parsing of chainport status API to new interface (#5030)
patnir Jun 14, 2024
ea0fd34
update chainport transaction api types (#5047)
patnir Jun 17, 2024
618f07b
Use `cli-progress` library directly instead of via oclif (#5046)
mat-if Jun 17, 2024
04d37fa
adds networkId to wallet, accountImport (#5042)
hughy Jun 17, 2024
415528c
Fix transactions cmd not handling streaming errors (#5053)
NullSoldier Jun 18, 2024
4e63986
Update axios to 1.7.2 (#5050)
dguenther Jun 18, 2024
fedd9d0
Change `initializeSapling` to avoid cloning
andiflabs Jun 18, 2024
c237236
Improve the calculation for the number of workers in the worker pool
andiflabs Jun 13, 2024
f475882
Change `DecryptNotesRequest` to require a common list of accounts and…
andiflabs Jun 14, 2024
a820f30
Change `DecryptNotesResponse` to use a sparse serialization format
andiflabs Jun 17, 2024
88a34b9
removes references to account createdAt hash (#5060)
hughy Jun 20, 2024
b81c53f
fixes workerMessages perf test (#5064)
hughy Jun 20, 2024
e9b5cbb
Have WalletScanner use chain directly if available (#5063)
NullSoldier Jun 20, 2024
6128fde
supports setting createdAt on account import (#5062)
hughy Jun 20, 2024
eed7f0e
Adds error handling to chainport requests (#5059)
patnir Jun 21, 2024
c14b401
Use `inquirer` for confirm prompt (#5061)
mat-if Jun 21, 2024
f0f8942
Revert "Have WalletScanner use chain directly if available (#5063)" (…
NullSoldier Jun 24, 2024
66e195d
Replaces isAddress depdenency with our own implementation (#5037)
patnir Jun 24, 2024
0ac6ce8
updates error handling to their new API response 400 object (#5069)
patnir Jun 24, 2024
e57b1a0
version bump for v2.4 (#5070)
patnir Jun 24, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
9 changes: 6 additions & 3 deletions .github/workflows/build-ironfish-rust-nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ jobs:
working-directory: ./ironfish-rust-nodejs

- name: Upload artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: bindings-${{ matrix.settings.target }}
path: ironfish-rust-nodejs/*.node
Expand All @@ -85,9 +85,12 @@ jobs:
fail-fast: false
matrix:
settings:
- host: macos-latest
- host: macos-13
target: x86_64-apple-darwin

- host: macos-latest
target: aarch64-apple-darwin

- host: windows-latest
target: x86_64-pc-windows-msvc

Expand Down Expand Up @@ -124,7 +127,7 @@ jobs:
node-version: 18

- name: Download artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: bindings-${{ matrix.settings.target }}
path: ./ironfish-rust-nodejs
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ jobs:

steps:
- name: Check out Git repository
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Use Node.js
uses: actions/setup-node@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy-brew.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
jobs:
Deploy:
name: Deploy
runs-on: macos-12
runs-on: macos-13

steps:
- name: Check out Git repository
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish-binaries.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
fail-fast: false
matrix:
settings:
- host: macos-latest
- host: macos-13
arch: x86_64
system: apple

Expand All @@ -29,7 +29,7 @@ jobs:
arch: x86_64
system: linux

- host: macos-latest-xlarge
- host: macos-latest
arch: arm64
system: apple

Expand Down
14 changes: 6 additions & 8 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

27 changes: 15 additions & 12 deletions ironfish-cli/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ironfish",
"version": "2.3.0",
"version": "2.4.0",
"description": "CLI for running and interacting with an Iron Fish node",
"author": "Iron Fish <[email protected]> (https://ironfish.network)",
"main": "build/src/index.js",
Expand Down Expand Up @@ -34,7 +34,7 @@
"eslint-plugin-deprecation": "2.0.0",
"jest": "29.7.0",
"jest-jasmine2": "29.7.0",
"oclif": "2.6.0",
"oclif": "3.7.2",
"rimraf": "^3.0.2",
"ts-jest": "29.1.1",
"tsc-watch": "4.2.9",
Expand All @@ -58,26 +58,25 @@
"oclif:version": "oclif readme && git add README.md"
},
"dependencies": {
"@aws-sdk/client-cognito-identity": "3",
"@aws-sdk/client-s3": "3",
"@aws-sdk/client-secrets-manager": "3",
"@aws-sdk/s3-request-presigner": "3",
"@ironfish/rust-nodejs": "2.3.0",
"@ironfish/sdk": "2.3.0",
"@oclif/core": "1.23.1",
"@ironfish/rust-nodejs": "2.4.0",
"@ironfish/sdk": "2.4.0",
"@oclif/core": "3.27.0",
"@oclif/plugin-autocomplete": "1.3.10",
"@oclif/plugin-help": "5.1.12",
"@oclif/plugin-not-found": "2.3.1",
"@oclif/plugin-warn-if-update-available": "2.0.40",
"@oclif/plugin-autocomplete": "1.3.10",
"@types/keccak": "3.0.4",
"@types/tar": "6.1.1",
"axios": "0.21.4",
"axios": "1.7.2",
"bech32": "2.0.0",
"blessed": "0.1.81",
"blru": "0.1.6",
"buffer-map": "0.0.7",
"chalk": "4.1.2",
"cli-progress": "3.12.0",
"inquirer": "8.2.5",
"json-colorizer": "2.2.2",
"keccak": "3.0.4",
"supports-hyperlinks": "2.2.0",
"tar": "6.1.11",
"uuid": "8.3.2"
Expand All @@ -97,7 +96,11 @@
"@oclif/plugin-warn-if-update-available",
"@oclif/plugin-autocomplete"
],
"topics": {}
"topics": {
"wallet:scanning": {
"description": "Turn on or off scanning for accounts"
}
}
},
"bin": {
"ironfish": "./bin/run"
Expand Down
23 changes: 20 additions & 3 deletions ironfish-cli/src/args.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,24 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */

export function parseNumber(input: string): number | null {
const parsed = Number(input)
return isNaN(parsed) ? null : parsed
import { parseUrl as parseUrlSdk } from '@ironfish/sdk'
import { Args } from '@oclif/core'

type Url = {
protocol: string | null
hostname: string
port: number | null
}

export function parseUrl(input: string): Promise<Url> {
const parsed = parseUrlSdk(input)
if (parsed.hostname != null) {
return Promise.resolve(parsed as Url)
} else {
return Promise.reject(new Error(`Invalid URL: ${input}`))
}
}

export const UrlArg = Args.custom<Url>({
parse: async (input: string) => parseUrl(input),
})
175 changes: 0 additions & 175 deletions ironfish-cli/src/commands/backup.ts

This file was deleted.

Loading
Loading