This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
conform to the uint32 type defined in dp-service for Status code #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vlorinc Could you check if this change would break things as you are actively working on it? |
byteocean
changed the title
|
@byteocean I changed the types of errors.Ignore function to uint32 as it needs to be of same type. Other than that it looks OK. |
|
@vlorinc thanks a lot. then I make it an official PR. |
guvenc
approved these changes
Oct 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is defined in the proto file in dp-service main branch, the code field is uint32 instead of int32, thus the relevant proto files are recompiled to conform to this change.