This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
Automated testing #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guvenc Gulce <[email protected]>
Signed-off-by: Guvenc Gulce <[email protected]>
Signed-off-by: Guvenc Gulce <[email protected]>
Signed-off-by: Guvenc Gulce <[email protected]>
Bumps [github.com/golang/protobuf](https://github.com/golang/protobuf) from 1.5.2 to 1.5.3. - [Release notes](https://github.com/golang/protobuf/releases) - [Commits](golang/protobuf@v1.5.2...v1.5.3) --- updated-dependencies: - dependency-name: github.com/golang/protobuf dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
- Add tool fetching in Makefile for addlicense, goimports and go-proto-gen tools - Regenerate proto files with new tools versions
Signed-off-by: Guvenc Gulce <[email protected]>
Bumps google.golang.org/protobuf from 1.28.1 to 1.31.0. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.53.0 to 1.59.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.53.0...v1.59.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Guvenc Gulce <[email protected]>
guvenc
suggested changes
Dec 12, 2023
There was a problem hiding this comment.
@vlorinc
This PR has 42 commits. Looks like you merged the main branch to development branch.
Please create a new PR branch. Dont change this one but a create new branch based on main and just cherry pick the commits relevant to this new change on that new PR branch and open a new PR.
| @@ -1,7 +1,7 @@ | |||
| name: test | |||
|
|
|||
| on: | |||
| pull_request: | |||
| pull_request_target: | |||
There was a problem hiding this comment.
Please use pull_request and not "pull_request_target".
This is a change we did during the immigration.
|
Changes in this PR are merged with another PR #52 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added automated tests of grpc client functions.