Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'type' to schema's Limit Object #29

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ignpelloz
Copy link
Member

Often, proxies can be configured in two ways for handling requests and applying rate limiting: average and burst. For example, if an endpoint allows 10 requests per minute:

  • Average: Would allow an average of 10 requests per minute, meaning only one request every 6 seconds would be accepted. Any other request received within these 6-second intervals would be rejected with HTTP code 429.
  • Burst: Would allow all 10 requests to be served at the any time during the minute. Once 10 requests have been served and until the end of the minute, all successive requests would be rejected with HTTP code 429.

With this PR I have modified the schema to allow specifying on the SLA how the API handles requests targeting a given endpoint: Limit Object's type can be set to burst or average.

(cc @pafmon)

@msewell-epi msewell-epi mentioned this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant