Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Point all transforms to same id #27

Merged
merged 1 commit into from
Oct 12, 2023
Merged

🐛 Point all transforms to same id #27

merged 1 commit into from
Oct 12, 2023

Conversation

heytherewill
Copy link
Contributor

Bug found by Pedro where you could have multiple Position if one was added via the IMurderTransformComponent extensions and the other via the Position extensions

@heytherewill heytherewill force-pushed the will/position-code-generation-fix branch from 7b4a92d to 4215979 Compare October 12, 2023 05:54
isadorasophia
isadorasophia approved these changes Oct 12, 2023
View reviewed changes
Copy link
Owner

@isadorasophia isadorasophia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks will! o/

@isadorasophia isadorasophia merged commit 2e291fa into isadorasophia:main Oct 12, 2023
4 checks passed
@heytherewill heytherewill deleted the will/position-code-generation-fix branch October 12, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isadorasophia isadorasophia isadorasophia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heytherewill @isadorasophia