-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Processor: Allow client to specify progress callback function #128
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #128 +/- ##
==========================================
+ Coverage 90.52% 90.73% +0.20%
==========================================
Files 85 85
Lines 6082 6176 +94
Branches 611 611
==========================================
+ Hits 5506 5604 +98
+ Misses 544 540 -4
Partials 32 32 ☔ View full report in Codecov by Sentry. |
Hello Dan. I don't know if it's the correct place to ask. I can move it to issues if preferred. |
Yes, I would expose it to Python. I am wondering if I should also extend it to directly provide a progress percentage. |
It would be nice to have that as well. I wonder how it would work in Python API.
Am I thinking about it correctly? |
@JakubCha Currently yes, the progress callback is invoked either once per feature or once per raster chunk. In the per-chunk case, the caller has no simple way to know how many chunks there will be, so I've updated the progress bar to take two arguments: the fraction completed, and an informational message. This would also allow providing more frequent progress updates when a feature needs to subdivided to limit memory usage, or when a raster chunk has many intersecting features. |
No description provided.