Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Pass NODATA values to Python functions #146

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

dbaston
Copy link
Member

@dbaston dbaston commented Aug 23, 2024

Resolves #136. Both values and weights will be masked arrays.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 97.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.98%. Comparing base (bf8315a) to head (f4371dd).
Report is 1 commits behind head on master.

Files Patch % Lines
src/raster_stats.h 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
+ Coverage   90.95%   90.98%   +0.03%     
==========================================
  Files          85       85              
  Lines        6332     6358      +26     
  Branches      622      627       +5     
==========================================
+ Hits         5759     5785      +26     
  Misses        541      541              
  Partials       32       32              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbaston dbaston merged commit 06669b0 into isciences:master Aug 26, 2024
20 checks passed
@dbaston
Copy link
Member Author

dbaston commented Aug 26, 2024

@JakubCha is this change OK on your end?

@JakubCha
Copy link
Contributor

@JakubCha is this change OK on your end?

@dbaston checked with the current lib version after the merge and it seems to be fine in the plugin. As long as NODATA is correctly defined in the raster metadata, the plugin will return NULL if there are no valid pixels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Python functions should receive NODATA pixels
2 participants