-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helper-function: fix formatting of bpf_probe_read_user_str.md #75
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this!
This bit of the docs is actually auto generated from the libbpf headers (see <!-- [HELPER_FUNC_DEF] -->
and <!-- [/HELPER_FUNC_DEF] -->
markers).
I suggest we remove these markers, so this will not be reverted next time we run the make generate-docs
command and take ownership of the definition ourselfs.
Fix formatting of the code block and some inline codes.
Thanks for your review! I have removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for the fix.
It seems that brought the wrath of CI, after fixing that we should be good.
Co-authored-by: Dylan Reimerink <[email protected]>
Co-authored-by: Dylan Reimerink <[email protected]>
Co-authored-by: Dylan Reimerink <[email protected]>
Co-authored-by: Dylan Reimerink <[email protected]>
Fix formatting of the code block and some inline codes.