Update bpf_get[_ns]_current_pid_tgid helper function data #89
+111
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since v6.10, the `bpf_get[_ns]_current_pid_tgid` helper functions can be used in all program types. This was not reflected in the docs. Since we want to reflect the version in the references, we are keeping the existing program associations and adding a new mention of the helpers in the "base" group with the `since` attribute. The intended purpose is so all programs that could use them before are not annotated with the `since` info, but all programs where support is new do have the version info. However, turns out the group flattening logic did not respect the hierarchy of the groups, so the `since` attribute was always shown. So the tool was updated, groups are resolved first, if a more specific group or more specific program type declares it as well, the newer declaration is used. This results in the intended behavior. Signed-off-by: Dylan Reimerink <[email protected]>
Apparently the pages for the HID BPF helper functions were not updated after the sleepable flag was added to the kfuncs data file. So it got updated when running the `make generate-docs` command for the last commit. Signed-off-by: Dylan Reimerink <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since v6.10, the
bpf_get[_ns]_current_pid_tgidhelper functions can beused in all program types. This was not reflected in the docs.
Since we want to reflect the version in the references, we are keeping
the existing program associations and adding a new mention of the
helpers in the "base" group with the
sinceattribute. The intendedpurpose is so all programs that could use them before are not annotated
with the
sinceinfo, but all programs where support is new do have theversion info.
However, turns out the group flattening logic did not respect the
hierarchy of the groups, so the
sinceattribute was always shown.So the tool was updated, groups are resolved first, if a more specific
group or more specific program type declares it as well, the newer
declaration is used. This results in the intended behavior.