Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add outputs for VPN gateway and route table #2

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

hhoover
Copy link
Contributor

@hhoover hhoover commented Nov 17, 2022

This commit also has README updates for said outputs

Copy link
Contributor

@bmcustodio bmcustodio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits (and you'll likely have to re-run make docs).

outputs.tf Outdated Show resolved Hide resolved
outputs.tf Outdated Show resolved Hide resolved
@hhoover
Copy link
Contributor Author

hhoover commented Nov 21, 2022

resolved, please re-review 😄

@bmcustodio
Copy link
Contributor

@hhoover I realize I'm pretty late here 😅 Is this still relevant?

@hhoover
Copy link
Contributor Author

hhoover commented Jun 12, 2024

It would be nice, but looks like I need to update / redo the PR. sets reminder

This commit also has README updates for said outputs
@hhoover
Copy link
Contributor Author

hhoover commented Jun 18, 2024

@bmcustodio done with what's different, please review

@PhilipSchmid PhilipSchmid merged commit a86eb18 into main Jul 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants