add helm repo add command
#37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add helm repo add command to add the cilium helm repo
|
Hi, I think it might be a good idea to add the helm repo directly in the provisioner as well. |
PhilipSchmid
reviewed
Jun 3, 2024
There was a problem hiding this comment.
Hi @steled,
Thanks for your suggestion! However, we once explicitly decided not to build Helm repo handling into our Terraform modules. One might want to use this module only with another Helm repo, e.g., a private Helm repo mirror.
Still, I agree that we should document this prerequisite. I'm about to send a PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helm repo addcommand to add the cilium helm repo