fix dataset conversion; fixed example datasets, torch geom list #39

mishadr · 2024-12-03T12:55:41Z

No description provided.

LukyanovKirillML

Не везде указаны типы там где это возможно. Например, source_dir явно str или Path.

Шапки функций стоит переписать. Чтобы было одинаково с остальной частью проекта.
def def_name(
arg1: type,
arg2: type
)

LukyanovKirillML · 2024-12-03T13:18:21Z

src/base/datasets_processing.py

@@ -988,6 +1054,32 @@ def _register_torch_geometric(
        return gen_dataset


+def merge_directories(source_dir, destination_dir, remove_source=False):


Например, где стиль шапки метода остался старый.

fix dataset conversion; fixed example datasets, torch geom list

18a12c3

LukyanovKirillML reviewed Dec 3, 2024

View reviewed changes

fix style, comments, unused code

9cdb678

mishadr force-pushed the dataset_convert branch from 48f1db0 to 9cdb678 Compare December 3, 2024 13:29

LukyanovKirillML approved these changes Dec 3, 2024

View reviewed changes

LukyanovKirillML merged commit f4b2298 into develop Dec 3, 2024
3 checks passed

LukyanovKirillML deleted the dataset_convert branch December 3, 2024 13:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix dataset conversion; fixed example datasets, torch geom list #39

fix dataset conversion; fixed example datasets, torch geom list #39

mishadr commented Dec 3, 2024

LukyanovKirillML left a comment

LukyanovKirillML Dec 3, 2024

		@@ -988,6 +1054,32 @@ def _register_torch_geometric(
		return gen_dataset


		def merge_directories(source_dir, destination_dir, remove_source=False):

fix dataset conversion; fixed example datasets, torch geom list #39

fix dataset conversion; fixed example datasets, torch geom list #39

Conversation

mishadr commented Dec 3, 2024

LukyanovKirillML left a comment

Choose a reason for hiding this comment

LukyanovKirillML Dec 3, 2024

Choose a reason for hiding this comment