Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Casr-js #176

Merged
merged 23 commits into from
Dec 12, 2023
Merged

Casr-js #176

merged 23 commits into from
Dec 12, 2023

Conversation

PaDarochek
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (dd9f727) 62.27% compared to head (74c731e) 62.67%.
Report is 7 commits behind head on master.

❗ Current head 74c731e differs from pull request most recent head 3f37b35. Consider uploading reports for the commit 3f37b35 to get more accurate results

Files Patch % Lines
casr/src/bin/casr-cli.rs 0.00% 12 Missing ⚠️
casr/src/bin/casr-js.rs 93.83% 9 Missing ⚠️
casr/src/bin/casr-libfuzzer.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
+ Coverage   62.27%   62.67%   +0.40%     
==========================================
  Files          30       31       +1     
  Lines        7012     7264     +252     
==========================================
+ Hits         4367     4553     +186     
- Misses       2645     2711      +66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PaDarochek PaDarochek force-pushed the casr-js branch 2 times, most recently from c45ab02 to 209337f Compare November 14, 2023 15:13
@PaDarochek PaDarochek marked this pull request as ready for review November 14, 2023 16:35
Copy link
Member

@hkctkuy hkctkuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update README

casr/tests/tests.rs Outdated Show resolved Hide resolved
casr/tests/tests.rs Show resolved Hide resolved
casr/src/bin/casr-cli.rs Show resolved Hide resolved
casr/src/bin/casr-js.rs Outdated Show resolved Hide resolved
casr/src/bin/casr-js.rs Outdated Show resolved Hide resolved
casr/tests/casr_tests/js/crash Outdated Show resolved Hide resolved
@SweetVishnya SweetVishnya self-requested a review November 16, 2023 06:37
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@SweetVishnya
Copy link
Collaborator

Can we add xml2js as an example in README?

README.md Show resolved Hide resolved
casr/src/bin/casr-libfuzzer.rs Show resolved Hide resolved
@SweetVishnya
Copy link
Collaborator

SweetVishnya commented Dec 3, 2023

test_casr_libfuzzer_jazzer_js_xml2js seems to fail in CI

casr/src/bin/casr-js.rs Outdated Show resolved Hide resolved
casr/src/bin/casr-js.rs Outdated Show resolved Hide resolved
casr/tests/tests.rs Outdated Show resolved Hide resolved
casr/src/bin/casr-js.rs Outdated Show resolved Hide resolved
casr/tests/tests.rs Show resolved Hide resolved
casr/src/bin/casr-js.rs Outdated Show resolved Hide resolved
@SweetVishnya
Copy link
Collaborator

Btw, test_casr_libfuzzer_jazzer_js_xml2js is still failing

Copy link
Collaborator

@SweetVishnya SweetVishnya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two things left: wait for the green CI and manually test casr-libfuzzer

Copy link
Collaborator

@SweetVishnya SweetVishnya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, test_casr_libfuzzer_jazzer_js_xml2js still fails

@PaDarochek PaDarochek force-pushed the casr-js branch 2 times, most recently from d15426f to 93a1dd7 Compare December 8, 2023 13:42
@PaDarochek
Copy link
Member Author

Unfortunately, test_casr_libfuzzer_jazzer_js_xml2js still fails

Fixed

Copy link
Collaborator

@SweetVishnya SweetVishnya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then the only thing left is to manually run casr-libfuzzer on js example

docs/usage.md Outdated Show resolved Hide resolved
casr/tests/tests.rs Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@SweetVishnya SweetVishnya merged commit 4644ee0 into ispras:master Dec 12, 2023
8 checks passed
@PaDarochek PaDarochek deleted the casr-js branch December 12, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Jazzer.js for JavaScript fuzzing Support crash triaging for jsfuzz
5 participants