Add `casr-lua` #231

hkctkuy · 2024-11-29T23:10:52Z

No description provided.

SweetVishnya · 2024-11-30T08:24:33Z

@hkctkuy, can you, also, please add casr-lua calls into casr-libfuzzzer. Thus, output from luzzer could be triaged.

SweetVishnya · 2024-11-30T08:28:36Z

@ligurio, can you help testing Lua crash analysis added in this PR?

ligurio · 2024-11-30T11:04:24Z

@SweetVishnya Sure, will do after weekend.

codecov · 2024-11-30T20:20:34Z

Codecov Report

Attention: Patch coverage is 81.53310% with 53 lines in your changes missing coverage. Please review.

Project coverage is 66.38%. Comparing base (af9e9e4) to head (0171139).

Files with missing lines	Patch %	Lines
libcasr/src/lua.rs	81.74%	23 Missing ⚠️
casr/src/bin/casr-lua.rs	88.00%	15 Missing ⚠️
casr/src/bin/casr-cli.rs	0.00%	12 Missing ⚠️
libcasr/src/report.rs	75.00%	2 Missing ⚠️
libcasr/src/python.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
+ Coverage   65.87%   66.38%   +0.51%     
==========================================
  Files          32       34       +2     
  Lines        7879     8154     +275     
==========================================
+ Hits         5190     5413     +223     
- Misses       2689     2741      +52

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ligurio

Thanks for the patch!
In general, it works, but with limitations. Seem comments inline.

ligurio · 2024-12-02T12:29:00Z

casr/src/bin/casr-lua.rs

+
+    // Extract lua exception
+    let Some(exception) = LuaException::new(&stderr) else {
+        bail!("Lua exception is not found!");


imagine a Lua code like the following:

[0] ~/sources/casr $ cat exc6.lua #!/bin/env lua function a() error("Boom!", 3); end function b() a(); end function c() b(); end function d() c(); end function e() d(); end function f() e(); end function errhandler(msg) print (msg .. "\nstack traceback: \n" .. debug.traceback(2, 3, 2)); end xpcall(f, errhandler);

that produces an output:

[0] ~/sources/casr $ ./exc6.lua ./exc6.lua:9: Boom! stack traceback: 2 stack traceback: ./exc6.lua:4: in function 'a' ./exc6.lua:7: in function 'b' ./exc6.lua:9: in function 'c' ./exc6.lua:11: in function 'd' ./exc6.lua:13: in function 'e' ./exc6.lua:15: in function <./exc6.lua:15> [C]: in function 'xpcall' ./exc6.lua:21: in main chunk [C]: in ?

casr-lua will not find traceback there:

$ ./target/debug/casr-lua -o lua.casrep -- ./exc6.lua Error: Lua exception is not found!

The error occurs only due to extra spaces after traceback

We can think about storing custom (maybe multiline) error as Explanation or Description fields, but it's not clear how to extract ShortDescription or etc

ligurio · 2024-12-02T12:34:14Z

casr/src/bin/casr-lua.rs

+
+    // Extract lua exception
+    let Some(exception) = LuaException::new(&stderr) else {
+        bail!("Lua exception is not found!");


Lua code:

#!/bin/env lua local function f1() error('error is triggered', 1) end local function f2() f1() end local function f3() f2() end local function f4() f3() end local function f5() f4() end local thread = coroutine.create(f5) local executed_ok, message = coroutine.resume(thread) if not executed_ok then print("Error: "..message.." in ".. debug.traceback(thread)) end

[0] ~/sources/casr $ lua exc2.lua Error: exc2.lua:4: error is triggered in stack traceback: [C]: in function 'error' exc2.lua:4: in function 'f1' exc2.lua:8: in function 'f2' exc2.lua:12: in function 'f3' exc2.lua:16: in function 'f4' exc2.lua:20: in function <exc2.lua:19> [0] ~/sources/casr $ ./target/debug/casr-lua -o lua.casrep -- ./exc2.lua Error: Lua exception is not found! [0] ~/sources/casr $

Should it be supported?

Hm... I assumed there was always going to be something like [C] in ? or [C] at 0xdeadbeaf at the end of traceback, but apparently it's not

Wait... That's just debug info in stdout, not error message (although it contains word Error)
Is it possible to rewrite this logging message to stderr?

The second issue is multiple call of debug.traceback()

To sum up the above, I think we should not to support it

+1
Custom error messages are not something that we want to support

ligurio · 2024-12-02T12:36:44Z

casr/src/bin/casr-lua.rs

+
+    // Extract lua exception
+    let Some(exception) = LuaException::new(&stderr) else {
+        bail!("Lua exception is not found!");


Stack trace for assertions does not work:

[1] ~/sources/casr $ cat exc7.lua #!/bin/env lua assert(nil, 'dddd') [1] ~/sources/casr $ lua exc7.lua lua: exc7.lua:3: dddd stack traceback: [C]: in function 'assert' exc7.lua:3: in main chunk [C]: in ? [1] ~/sources/casr $ ./target/debug/casr-lua -o lua.casrep -- ./exc7.lua (empty)

Idk, It works fine for me

Avgor46 · 2024-12-07T18:16:23Z

libcasr/src/lua.rs

+        })
+    }
+    /// Extract stack trace from lua exception.
+    pub fn extract_stacktrace(&self) -> Result<Vec<String>> {


For stacktrace and exception we have different interfaces. Why is this code here?

The word exception in the interaface name can create confusion.
I just want to create additional layer of abstruction like UbsanWarning and use resulting interface for safe work with all necessary methods from ParseStacktrace, CrashLineExt and Severity.
Maybe it's worth to renaming it to LuaError or etc.

I think we should handle Lua errors the same way we handle errors in other supported languages. We should implement the Exception trait for LuaError like here

But it's already implement the Severity trait

The main idea is transfer more parse logic to lib for having single entry point like for UbsanWarning.
In result you just give stream to lib and recieve all necessary info.

libcasr/src/lua.rs

SweetVishnya · 2024-12-19T16:52:05Z

libcasr/fuzz/fuzz_targets/parse_stacktrace.rs

-            // Go
-            if let Ok(raw) = GoStacktrace::extract_stacktrace(&s) {
-                if let Ok(st) = GoStacktrace::parse_stacktrace(&raw) {
+            // C#


Fix match above:

match data[0] % 8

SweetVishnya · 2024-12-19T16:53:15Z

libcasr/fuzz/fuzz_targets/parse_stacktrace.rs

@@ -30,17 +31,17 @@ fuzz_target!(|data: &[u8]| {
            }
        }
        1 => {
-            // Go
-            if let Ok(raw) = GoStacktrace::extract_stacktrace(&s) {


If you chenge numbering here, you should also change corpus files

hkctkuy added 10 commits November 29, 2024 20:36

casr-lua initial commit: add LuaStacktrace

d4eeeea

Add CrashLineExt impl

68aba4c

Add Severity impl

0b1c712

FIx clippy

8287fb0

Add casr-lua

0edebae

Add bin test

0d8c6e5

Update workflows

15de25f

Update docs

186078b

Update casr-cli

d644b14

Update gitignore

9542a37

hkctkuy requested review from SweetVishnya and Avgor46 November 29, 2024 23:10

hkctkuy linked an issue Nov 29, 2024 that may be closed by this pull request

Support Lua programming language #219

Open

FIx clippy

e3e8c3a

Add fuzzing

7c7c7c2

ligurio reviewed Dec 2, 2024

View reviewed changes

hkctkuy added 2 commits December 2, 2024 22:20

Rework regexps

94a0235

Merge tests

d4606fd

hkctkuy requested a review from ligurio December 2, 2024 19:49

Avgor46 reviewed Dec 7, 2024

View reviewed changes

Fixes

0171139

hkctkuy requested a review from Avgor46 December 8, 2024 15:10

SweetVishnya reviewed Dec 19, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `casr-lua` #231

Add `casr-lua` #231

hkctkuy commented Nov 29, 2024

SweetVishnya commented Nov 30, 2024

SweetVishnya commented Nov 30, 2024

ligurio commented Nov 30, 2024

codecov bot commented Nov 30, 2024 •

edited

Loading

ligurio left a comment

ligurio Dec 2, 2024

hkctkuy Dec 2, 2024

hkctkuy Dec 2, 2024

hkctkuy Dec 2, 2024

ligurio Dec 2, 2024

hkctkuy Dec 2, 2024

hkctkuy Dec 2, 2024

hkctkuy Dec 2, 2024

hkctkuy Dec 2, 2024

Avgor46 Dec 3, 2024

ligurio Dec 2, 2024

hkctkuy Dec 2, 2024

Avgor46 Dec 7, 2024

hkctkuy Dec 7, 2024 •

edited

Loading

Avgor46 Dec 7, 2024

hkctkuy Dec 7, 2024

hkctkuy Dec 7, 2024

SweetVishnya Dec 19, 2024

SweetVishnya Dec 19, 2024

Add casr-lua #231

Are you sure you want to change the base?

Add casr-lua #231

Conversation

hkctkuy commented Nov 29, 2024

SweetVishnya commented Nov 30, 2024

SweetVishnya commented Nov 30, 2024

ligurio commented Nov 30, 2024

codecov bot commented Nov 30, 2024 • edited Loading

Codecov Report

ligurio left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hkctkuy Dec 7, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Add `casr-lua` #231

Add `casr-lua` #231

codecov bot commented Nov 30, 2024 •

edited

Loading

hkctkuy Dec 7, 2024 •

edited

Loading