Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compose action #40

Merged
merged 13 commits into from
Oct 9, 2024
Merged

Compose action #40

merged 13 commits into from
Oct 9, 2024

Conversation

MatthewZMSU
Copy link
Contributor

Description

Implemented Compose action which is capable of combining several PuppeteerActions into one.
Also I have fixed several bugs.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested it locally with several spiders. One new added to the repository.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

mxsnq
mxsnq reviewed Sep 12, 2024
View reviewed changes
scrapypuppeteer/browser_managers/playwright_browser_manager.py Outdated Show resolved Hide resolved
scrapypuppeteer/browser_managers/playwright_browser_manager.py Outdated Show resolved Hide resolved
examples/spiders/compose.py Outdated Show resolved Hide resolved
scrapypuppeteer/browser_managers/pyppeteer_browser_manager.py Outdated Show resolved Hide resolved
scrapypuppeteer/actions.py Show resolved Hide resolved
scrapypuppeteer/actions.py Show resolved Hide resolved
@MatthewZMSU
Merge remote-tracking branch 'origin/master' into compose-action
0c30f5e 
# Conflicts:
#	scrapypuppeteer/actions.py
#	scrapypuppeteer/browser_managers/service_browser_manager.py
@MatthewZMSU
Fixed stand-alone Compose.
dfe7d77
@MatthewZMSU MatthewZMSU self-assigned this Sep 16, 2024
@MatthewZMSU MatthewZMSU added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 16, 2024
@mxsnq mxsnq merged commit 98704eb into master Oct 9, 2024
16 checks passed
@mxsnq mxsnq deleted the compose-action branch October 9, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxsnq mxsnq mxsnq approved these changes

Assignees

@MatthewZMSU MatthewZMSU

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatthewZMSU @mxsnq