Browser manager refactor #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f0f9641
MatthewZMSU
commented
Dec 20, 2024
| @@ -8,12 +8,12 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| include: | |||
| - python-version: "3.7.x" # Min Python version (No 3.6 version in GitHub repository) | |||
| - python-version: "3.8.x" | |||
| - python-version: "3.8.x" # Min Python version (No 3.7 version in GitHub repository) | |||
There was a problem hiding this comment.
GitHub dropped Python3.7 support
MatthewZMSU
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored browser managers so they now do not use
syncerandbs4. They do not skip middlewares after PuppeteerServiceDownloaderMiddleware. They do not log useless messages to the console.Temporiraly dropped Pyppeteer support since it is not actively maintained bu the community.
Slightly changed CI.
Added playwright test spider.
Added documentation
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested it locally with several scrapy spiders.
Checklist: