Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker, CI: Make JS integration tests more robust; update screenshots #1021

Merged
merged 5 commits into from
Apr 29, 2024

Conversation

ix5
Copy link
Member

@ix5 ix5 commented Apr 28, 2024

Checklist

  • All new and existing tests are passing
  • (If adding features:) I have added tests to cover my changes
  • (If docs changes needed:) I have updated the documentation accordingly.
  • I have added an entry to CHANGES.rst because this is a user-facing change or an important bugfix
  • I have written proper commit message(s)

What changes does this Pull Request introduce?

  • Rebuild the docker-js-testbed image weekly so that it doesn't get outdated and introduce subtle errors (previously, I - @ix5 - was building and pushing this image manually)
  • Pin the testbed Dockerfile to Debian Bookworm with Node 22
  • Check in updated screenshots (GitHub Actions was failing on this step since the base :current was implicitly updating the testbed image to Bookworm already)
  • Hopefully make the wait-for-health check more robust

Why is this necessary?

Flaky tests

ix5 added 3 commits April 29, 2024 00:22
This prevents unexpected jumps in Debian releases when the
`:current` tag changes and makes screenshot rendering more
predictable
Font rendering seems to have changed once again with the
jump from Debian Buster to Bookworm (the Dockerfile was
updated to pin Bookworm with Node 22)
@ix5 ix5 added bug testing/ci Test coverage & GitHub actions etc. labels Apr 28, 2024
@ix5 ix5 added this to the 0.14 milestone Apr 28, 2024
@ix5 ix5 marked this pull request as ready for review April 28, 2024 22:57
@ix5 ix5 merged commit ac9fb0d into isso-comments:master Apr 29, 2024
17 checks passed
@ix5 ix5 deleted the fix/ci branch April 29, 2024 00:28
@ix5 ix5 mentioned this pull request Apr 29, 2024
5 tasks
@ix5 ix5 modified the milestones: 0.14, 0.13.1 May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug testing/ci Test coverage & GitHub actions etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant