Add error message for improperly configured server.listen #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BBaoVanC
approved these changes
Jan 17, 2024
isso/__init__.py
Outdated
| sock = conf.get("server", "listen").partition("unix://")[2] | ||
| try: | ||
| os.unlink(sock) | ||
| except OSError as ex: | ||
| if ex.errno != errno.ENOENT: | ||
| raise | ||
| wsgi.SocketHTTPServer(sock, make_app(conf)).serve_forever() | ||
| else: | ||
| logger.error("server.listen must specif a protocol of http:// or unix://") |
There was a problem hiding this comment.
nit: should say "specify" instead of "specif"
If the protocol is not specified/wrong the error message is quite cryptic
sjrct
force-pushed
the
listen-proto-error-msg
branch
from
c7de10c
to
9bd86ae
Compare
|
@BBaoVanC if you're satisfied, I would like to merge this. |
ix5
added
server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
What changes does this Pull Request introduce?
Add error message for improperly configured
server.listenWhy is this necessary?
Otherwise the error message is quite cryptic, what I saw was ultimately: