feat(MPDZBS-877 ZMS-2517): Remove error_logs

it-at-m · Oct 4, 2024 · 2bd3f13 · 2bd3f13
1 parent 8f5f202
commit 2bd3f13
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 11 deletions.
diff --git a/zmscitizenapi/src/Zmscitizenapi/AppointmentUpdate.php b/zmscitizenapi/src/Zmscitizenapi/AppointmentUpdate.php
@@ -31,7 +31,7 @@ public function readResponse(RequestInterface $request, ResponseInterface $respo
         }
 
         try {
-            
+
             $reservedProcess = ZmsApiFacadeService::getProcessById($processId, $authKey);
             if (!empty($reservedProcess['errors'])) {
                 return $this->createJsonResponse($response, $reservedProcess, 404);

diff --git a/zmscitizenapi/src/Zmscitizenapi/Services/ZmsApiClientService.php b/zmscitizenapi/src/Zmscitizenapi/Services/ZmsApiClientService.php
@@ -155,18 +155,15 @@ public static function submitClientData($process)
             $result = \App::$http->readPostResult($url, $processEntity);
             return $result->getEntity();
         } catch (\Exception $e) {
-            error_log('Caught Exception: ' . $e->getMessage());
             $exceptionName = json_decode(json_encode($e), true)['template'] ?? null;
-            error_log('Exception Name: ' . $exceptionName);
             if ($exceptionName === 'BO\\Zmsapi\\Exception\\Process\\MoreThanAllowedAppointmentsPerMail') {
-                error_log("here");
                 $exception = [
                     'exception' => 'tooManyAppointmentsWithSameMail'
                 ];
                 return $exception;
             }
         }
-        
+
     }
 
     public function preconfirmProcess($process)

diff --git a/zmscitizenapi/tests/Zmscitizenapi/AppointmentUpdateTest.php b/zmscitizenapi/tests/Zmscitizenapi/AppointmentUpdateTest.php
@@ -68,7 +68,7 @@ public function testTooManyEmailsAtLocation()
 
         $exception = new \BO\Zmsclient\Exception();
         $exception->template = 'BO\\Zmsapi\\Exception\\Process\\MoreThanAllowedAppointmentsPerMail';
-    
+
         $this->setApiCalls(
             [
                 [
@@ -86,7 +86,7 @@ public function testTooManyEmailsAtLocation()
                 ]
             ]
         );
-    
+
         $parameters = [
             'processId' => '101002',
             'authKey' => 'fb43',
@@ -95,9 +95,9 @@ public function testTooManyEmailsAtLocation()
             'telephone' => '123456789',
             'customTextfield' => "Some custom text",
         ];
-    
+
         $response = $this->render([], $parameters, [], 'POST');
-        $responseBody = json_decode((string) $response->getBody(), true);      
+        $responseBody = json_decode((string) $response->getBody(), true);
         $expectedResponse = [
             'errors' => [
                 [
@@ -108,11 +108,11 @@ public function testTooManyEmailsAtLocation()
             ],
             'status' => 406
         ];
-    
+
         $this->assertEquals(406, $response->getStatusCode());
         $this->assertEqualsCanonicalizing($expectedResponse, $responseBody);
     }
-    
+
     public function testAppointmentNotFound()
     {
         $this->setApiCalls(
-Original file line number
+Diff line change
@@ Expand Up @@
             }
             try {
                 $reservedProcess = ZmsApiFacadeService::getProcessById($processId, $authKey);
                 if (!empty($reservedProcess['errors'])) {
                     return $this->createJsonResponse($response, $reservedProcess, 404);
@@ Expand Down @@