Skip to content

Commit

Permalink
Merge pull request #712 from it-at-m/cleanup-zms-3377-change-labels
Browse files Browse the repository at this point in the history
clean(ZMS-3377):  added new migration to change default text
  • Loading branch information
msfb3 authored Dec 6, 2024
2 parents e17942b + e2d3c84 commit 8b3caa4
Show file tree
Hide file tree
Showing 9 changed files with 26 additions and 13 deletions.
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -184,4 +184,3 @@ The branch name must match the following regular expression:
[license-shield]: https://img.shields.io/github/license/it-at-m/eappointment.svg?style=for-the-badge
[license-url]: https://github.com/it-at-m/eappointment/blob/main/LICENSE
[product-screenshot]: images/screenshot.png

6 changes: 3 additions & 3 deletions zmsadmin/custom_templates/block/appointment/form.twig
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@

{% block board_title %}
{% if selectedProcess %}
<span id="appointment-edit-title" tabindex="0">Terminvereinbarung Aktualisieren</span>
<span id="appointment-edit-title" tabindex="0">Termin aktualisieren</span>
{% else %}
Terminvereinbarung Neu
Termin erstellen
{% endif %}

<script>
Expand Down Expand Up @@ -248,7 +248,7 @@
{% endif %}
{{ formgroup(
{
"label": "Anmerkung",
"label": "Anmerkung (nur intern sichtbar)",
"checked": scope.preferences.client.amendmentActivated,
"class": "form-group--nomaxwidth",
"errors": formData.amendment.messages
Expand Down
6 changes: 3 additions & 3 deletions zmsadmin/templates/block/appointment/form.twig
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@

{% block board_title %}
{% if selectedProcess %}
<span id="appointment-edit-title" tabindex="0">Terminvereinbarung Aktualisieren</span>
<span id="appointment-edit-title" tabindex="0">Termin aktualisieren</span>
{% else %}
Terminvereinbarung Neu
Termin erstellen
{% endif %}

<script>
Expand Down Expand Up @@ -248,7 +248,7 @@
{% endif %}
{{ formgroup(
{
"label": "Anmerkung",
"label": "Anmerkung (nur intern sichtbar)",
"checked": scope.preferences.client.amendmentActivated,
"class": "form-group--nomaxwidth",
"errors": formData.amendment.messages
Expand Down
2 changes: 1 addition & 1 deletion zmsadmin/templates/block/appointment/formRedirect.twig
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@

{{ formgroup(
{
"label": "Anmerkung",
"label": "Anmerkung (nur intern sichtbar)",
"checked": scope.preferences.client.amendmentActivated,
"class": "form-group--nomaxwidth",
"errors": formData.amendment.messages
Expand Down
2 changes: 1 addition & 1 deletion zmsadmin/templates/block/queue/info.twig
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@

<li>
<div class="cell middle">
<h4>{% trans %}Wartezeit für neue Spontankunden in Stunden{% endtrans %}:</h4>
<h4>{% trans %}Wartezeit für neue Spontankunden in Minuten{% endtrans %}:</h4>
</div>
<div class="cell right">
{% if workstationInfo.workstationGhostCount == 0 %}
Expand Down
6 changes: 3 additions & 3 deletions zmsadmin/tests/Zmsadmin/AppointmentFormTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public function testRendering()
]
);
$response = parent::testRendering();
$this->assertStringContainsString('Terminvereinbarung Neu', (string)$response->getBody());
$this->assertStringContainsString('Termin erstellen', (string)$response->getBody());
$this->assertStringContainsString('title="Spontankunde"', (string)$response->getBody());
$this->assertStringContainsString('Liste leeren', (string)$response->getBody());
}
Expand Down Expand Up @@ -240,7 +240,7 @@ public function testSelectedProcess()
]
);
$response = $this->render([], ['selectedprocess' => 100044]);
$this->assertStringContainsString('Terminvereinbarung Aktualisieren', (string)$response->getBody());
$this->assertStringContainsString('Termin aktualisieren', (string)$response->getBody());
}

public function testSelectedDate()
Expand Down Expand Up @@ -290,7 +290,7 @@ public function testSelectedDate()
]
);
$response = $this->render([], ['selecteddate' => '2016-05-27']);
$this->assertStringContainsString('Terminvereinbarung Neu', (string)$response->getBody());
$this->assertStringContainsString('Termin erstellen', (string)$response->getBody());
$this->assertStringContainsString('2016-05-27', (string)$response->getBody());
$this->assertStringNotContainsString('slotCount', (string)$response->getBody());
}
Expand Down
2 changes: 1 addition & 1 deletion zmsadmin/tests/Zmsadmin/CounterQueueInfoTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ public function testTodayWithAdditionalInfo()
'selecteddate' => '2016-04-01'
], []);
$this->assertStringContainsString('davon vor nächstem Spontankunden', (string)$response->getBody());
$this->assertStringContainsString('Wartezeit für neue Spontankunden in Stunden', (string)$response->getBody());
$this->assertStringContainsString('Wartezeit für neue Spontankunden in Minuten', (string)$response->getBody());

$this->assertEquals(200, $response->getStatusCode());
}
Expand Down
7 changes: 7 additions & 0 deletions zmsdb/migrations/91732870750-custom-textfiled-label.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
BEGIN;

UPDATE `standort`
SET `custom_text_field_label` = 'Zusätzliche Bemerkungen (für Bürger*innen sichtbar)'
WHERE `custom_text_field_label` = '' OR `custom_text_field_label` IS NULL OR `custom_text_field_label` = 'Zusätzliche Bemerkungen';

COMMIT;
7 changes: 7 additions & 0 deletions zmsdb/migrations/91733411822-reserve-default-label-2.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
BEGIN;

UPDATE `standort`
SET `custom_text_field_label` = 'Zusätzliche Bemerkungen'
WHERE `custom_text_field_label` = '' OR `custom_text_field_label` IS NULL OR `custom_text_field_label` = 'Zusätzliche Bemerkungen (für Bürger*innen sichtbar)';

COMMIT;

0 comments on commit 8b3caa4

Please sign in to comment.