Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IdentityServer4 to completely switch to OpenIdDict #1206

Merged
merged 7 commits into from
Aug 29, 2023
Merged

Remove IdentityServer4 to completely switch to OpenIdDict #1206

merged 7 commits into from
Aug 29, 2023

Conversation

DmyMi
Copy link
Contributor

@DmyMi DmyMi commented Aug 26, 2023

Now possible to use latest versions of EF Core and other MS libs (was blocked by some IS4 dependencies).

This PR is mostly deleting files with some refactoring on naming

@DmyMi DmyMi requested a review from a team August 26, 2023 13:20
@github-actions github-actions bot requested a review from h4wk13 August 26, 2023 13:20
VadymLevkovskyi
VadymLevkovskyi approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@VadymLevkovskyi VadymLevkovskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in general.
There are minor traces of identityServer in services' constructor parameter name.
Also (bit irrelevant) I see that Sonar is down, so you are not protected from other possible issues.

@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

9.1% 9.1% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@DmyMi DmyMi merged commit 0670f52 into develop Aug 29, 2023
4 of 5 checks passed
@DmyMi DmyMi deleted the dmin/remove_is4 branch August 29, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VadymLevkovskyi VadymLevkovskyi VadymLevkovskyi approved these changes

@h4wk13 h4wk13 Awaiting requested review from h4wk13

Assignees

@DmyMi DmyMi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DmyMi @VadymLevkovskyi