Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kyryk/Implemented healthcheck endpoint #1584

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Kyryk/Implemented healthcheck endpoint #1584

merged 3 commits into from
Nov 27, 2024

Conversation

Tetyana-K
Copy link
Contributor

Implemented the ServiceController for handling health check requests.
Added unit tests to verify the functionality of the health check endpoint.

Work in progress.
Thank you to all reviewers for your time and feedback)

@VadymLevkovskyi
Copy link
Contributor

VadymLevkovskyi commented Oct 24, 2024

@Tetyana-K could you explain why we can't use standard approach for health checks from Asp.Net ?
Your code seems to be valid, but it's bit "excessive".

Copy link

sonarcloud bot commented Oct 25, 2024

@Tetyana-K
Copy link
Contributor Author

Thank you for the comment, I agree, corrected it.

@Tetyana-K Tetyana-K marked this pull request as ready for review October 25, 2024 17:58
Copy link

sonarcloud bot commented Nov 27, 2024

@DmyMi DmyMi merged commit 8ddd21a into develop Nov 27, 2024
9 checks passed
@DmyMi DmyMi deleted the healthcheck-endpoint branch November 27, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants