Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/importmap_compile #542

Merged
merged 8 commits into from
Oct 6, 2023
Merged

Fix/importmap_compile #542

merged 8 commits into from
Oct 6, 2023

Conversation

AndriyAndriyovuch
Copy link
Contributor

@AndriyAndriyovuch AndriyAndriyovuch commented Aug 11, 2023

Code reviewers

Summary of issue

Stimulus controlles aren't work

Summary of change

Fixed all importmaps and imports in application.js

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

@AndriyAndriyovuch AndriyAndriyovuch added the bug Something isn't working label Aug 11, 2023
@AndriyAndriyovuch AndriyAndriyovuch self-assigned this Aug 11, 2023
@render
Copy link

render bot commented Aug 11, 2023

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -8.92% ⚠️

Comparison is base (f8acd86) 85.34% compared to head (f61eb90) 76.43%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #542      +/-   ##
===========================================
- Coverage    85.34%   76.43%   -8.92%     
===========================================
  Files           64       64              
  Lines          778      802      +24     
===========================================
- Hits           664      613      -51     
- Misses         114      189      +75     
Files Changed Coverage Δ
app/controllers/account/calculators_controller.rb 52.77% <50.00%> (-36.12%) ⬇️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -3,3 +3,4 @@
//= require bootstrap
//= link_tree ../builds
//= link_tree ../../javascript .js
//= link tailwind.css
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

це в лейаут додай

@AndriyAndriyovuch AndriyAndriyovuch changed the title temporary_fix/importmap_compile Fix/importmap_compile Aug 17, 2023
app/javascript/application.js Show resolved Hide resolved
@@ -1,5 +1,6 @@
import { Controller } from "@hotwired/stimulus";
import { FetchRequest } from "@rails/request.js";
import toastr from "toastr";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а навіщо це тут?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@loqimean loqimean merged commit f62bbf1 into develop Oct 6, 2023
@loqimean loqimean deleted the fix/importmap_compile branch October 6, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants