Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/487_529_design_issues #543

Closed
wants to merge 2 commits into from
Closed

fix/487_529_design_issues #543

wants to merge 2 commits into from

Conversation

AndriyAndriyovuch
Copy link
Contributor

Code reviewers

Summary of issue

Change validation errors for Title field (Site Settings) #487
Change of the confirmation message #529

Summary of change

  • fixed message in locale
  • added "if" condition in model's validation

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

@AndriyAndriyovuch AndriyAndriyovuch added the Improvement Suggestion to make the product better label Sep 16, 2023
@AndriyAndriyovuch AndriyAndriyovuch self-assigned this Sep 16, 2023
@render
Copy link

render bot commented Sep 16, 2023

Your Render PR Server URL is https://zero-waste-staging-pr-543.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-ck2pc1hitvpc73cdu6d0.

@sonarcloud
Copy link

sonarcloud bot commented Sep 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AndriyAndriyovuch AndriyAndriyovuch changed the title Fix/487 529 design issues fix/487_529_design_issues Sep 16, 2023
This was linked to issues Sep 16, 2023
[Site Settings page] Change of the confirmation message #529
Closed
Change validation errors for Title field (Site Settings) #487
Closed
@AndriyAndriyovuch AndriyAndriyovuch deleted the fix/487_529_design_issues branch September 17, 2023 10:53
This was unlinked from issues Sep 17, 2023
[Site Settings page] Change of the confirmation message #529
Closed
Change validation errors for Title field (Site Settings) #487
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loqimean loqimean Awaiting requested review from loqimean

Assignees

@AndriyAndriyovuch AndriyAndriyovuch

Labels
Improvement Suggestion to make the product better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AndriyAndriyovuch