Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/update_webdrivers #544

Merged
merged 1 commit into from
Oct 6, 2023
Merged

fix/update_webdrivers #544

merged 1 commit into from
Oct 6, 2023

Conversation

AndriyAndriyovuch
Copy link
Contributor

Code reviewers

Summary of issue

Capybara tests were failed beacouse of old version of webrivers

Summary of change

updated webdrivers gem

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

@AndriyAndriyovuch AndriyAndriyovuch added the bug Something isn't working label Sep 16, 2023
@AndriyAndriyovuch AndriyAndriyovuch self-assigned this Sep 16, 2023
@render
Copy link

render bot commented Sep 16, 2023

@sonarcloud
Copy link

sonarcloud bot commented Sep 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f8acd86) 85.34% compared to head (ac0a19b) 85.34%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #544   +/-   ##
========================================
  Coverage    85.34%   85.34%           
========================================
  Files           64       64           
  Lines          778      778           
========================================
  Hits           664      664           
  Misses         114      114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndriyAndriyovuch AndriyAndriyovuch changed the title fix/update gem webdrivers fix/update_webdrivers Sep 16, 2023
@loqimean loqimean merged commit 0f6eda7 into develop Oct 6, 2023
7 checks passed
@loqimean loqimean deleted the fix/chromedriver_update branch October 6, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants