#866-fix refreshing new Category page #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NVMakarenko
requested review from
olexandervanzuriak,
loqimean,
DanielVajnagi,
KseniaGovorun,
alexy78 and
ktpe
SleekMutt
approved these changes
Nov 19, 2024
alexy78
approved these changes
Nov 19, 2024
NVMakarenko
removed request for
olexandervanzuriak,
DanielVajnagi,
KseniaGovorun and
ktpe
loqimean
approved these changes
Nov 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #954 +/- ##
========================================
Coverage 91.76% 91.76%
========================================
Files 73 73
Lines 1044 1044
========================================
Hits 958 958
Misses 86 86 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
render
bot
temporarily deployed
to
866-refresh-new-category - zero-waste-staging PR #954
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev
PROJECT
Board ticket
Code reviewers
Second Level Review
Summary of issue
The issue is similar to Board ticket
New Category is not creating because of validation failed. Error message is shown. If change locale on this stage, admin will be redirected to Category's page.
category_issue.mp4
Expected result
'New Categories' page is reload and displayed.
'Name' field is blank.
Error message is absent.
Summary of change
fix_category.mp4
CHECK LIST