added calculator new specs; fixed controller; #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NVMakarenko
reviewed
Nov 19, 2024
| @@ -1,7 +1,6 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| class Account::CalculatorsController < Account::BaseController | |||
| before_action :resource, only: [:edit, :update, :destroy] | |||
| load_and_authorize_resource | |||
There was a problem hiding this comment.
maybe we should skip "load_and_authorize_resource", because we load resources and have only user aka Admin.
NVMakarenko
approved these changes
Nov 19, 2024
SleekMutt
approved these changes
Nov 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## calculators-constructor #958 +/- ##
===========================================================
+ Coverage 83.98% 84.29% +0.30%
===========================================================
Files 65 65
Lines 974 974
===========================================================
+ Hits 818 821 +3
+ Misses 156 153 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev
JIRA
Code reviewers
Second Level Review
Summary of issue
ToDo
Summary of change
added tests for Calculalor new.
Changed the code inside the Calculator controller.
Testing approach
ToDo
CHECK LIST