Fixed CI on the calculators constructor branch #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alculators. Also fixed Diapers calculator by returning related to it methods
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## calculators-constructor #960 +/- ##
==========================================================
Coverage ? 83.98%
==========================================================
Files ? 65
Lines ? 974
Branches ? 0
==========================================================
Hits ? 818
Misses ? 156
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
loqimean
reviewed
Nov 21, 2024
loqimean
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev
Code reviewers
Second Level Review
Summary of issue
Failed CI that needs to be fixed. Not working Diapers calculator that needs to be restored
Summary of change
Fixed CI by deleting the redundant code from the old constructor of calculators. Also fixed Diapers calculator by returning related to it methods and changing field relation to be optional.
CHECK LIST