Added flipper, so admin could enable or disable mhc calculator #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #969 +/- ##
===========================================
+ Coverage 91.76% 91.79% +0.03%
===========================================
Files 73 73
Lines 1044 1048 +4
===========================================
+ Hits 958 962 +4
Misses 86 86 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
ktpe
approved these changes
Nov 22, 2024
loqimean
requested changes
Nov 22, 2024
| @@ -52,4 +53,8 @@ def collection | |||
| def resource | |||
| collection.friendly.find(params[:slug]) | |||
| end | |||
|
|
|||
| def check_mhc_flipper | |||
| raise ActionController::RoutingError, "Mhc calculator flipper is disabled" unless Flipper[:mhc_calculator_status].enabled? | |||
There was a problem hiding this comment.
і краще спочатку умову мати з ретурном, а вже знизу от наприклад редірект, чи рейзання ерори, чи ще щось
loqimean
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unknown_2024.11.22-19.21_1.mp4
Code reviewers
Summary of issue
There is no feature flipper for the mhc calculator
Summary of change
Added feature flipper for the mhc calculator
CHECK LIST