Added feature flipper for calculators constructor #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## calculators-constructor #983 +/- ##
===========================================================
+ Coverage 85.41% 85.51% +0.09%
===========================================================
Files 68 68
Lines 1049 1056 +7
===========================================================
+ Hits 896 903 +7
Misses 153 153 ☔ View full report in Codecov by Sentry. |
loqimean
requested changes
Nov 28, 2024
| @@ -26,6 +26,20 @@ | |||
| end | |||
| end | |||
|
|
|||
| RSpec.shared_context :show_constructor do | |||
There was a problem hiding this comment.
Suggested change
| RSpec.shared_context :show_constructor do | |
| RSpec.shared_context :enable_calculators_constructor do |
loqimean
reviewed
Nov 28, 2024
spec/requests/calculators_spec.rb
Outdated
Comment on lines
13
to
15
| before(:example, :disabled_constructor) do | ||
| include_context :disable_calculators_constructor | ||
| end |
There was a problem hiding this comment.
щось не дуже розумію, що тут робиться
loqimean
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unknown_2024.11.26-17.17.mp4
Code reviewers
Second Level Review
Summary of issue
There is not feature flipper for the calculators constructor.
Summary of change
Added feature flipper for calculators constructor, so admin could turn on/off it
CHECK LIST