Save previous calculations of the user in the storage #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## calculators-constructor #993 +/- ##
===========================================================
+ Coverage 86.74% 87.05% +0.30%
===========================================================
Files 68 68
Lines 1056 1058 +2
===========================================================
+ Hits 916 921 +5
+ Misses 140 137 -3 ☔ View full report in Codecov by Sentry. |
loqimean
requested changes
Nov 29, 2024
app/views/calculators/show.html.erb
Outdated
|
|
||
| <%= turbo_frame_tag "calc-results" %> | ||
| <%= turbo_frame_tag "calc-results" do %> | ||
| <% if session.dig(:calculation_results, @calculator.slug)&.presence %> |
There was a problem hiding this comment.
Suggested change
| <% if session.dig(:calculation_results, @calculator.slug)&.presence %> | |
| <% if session.dig(:calculation_results, @calculator.slug).present?%> | |
loqimean
requested changes
Dec 1, 2024
app/views/calculators/show.html.erb
Outdated
| <%= turbo_frame_tag "calc-results" %> | ||
| <%= turbo_frame_tag "calc-results" do %> | ||
| <% if session.dig(:calculation_results, @calculator.slug).present? %> | ||
| <%= render "calculators/partials/calculation_results", results: session[:calculation_results][@calculator.slug].map(&:symbolize_keys) %> |
There was a problem hiding this comment.
- use
with_indifferent_access - use
dig
|
ktpe
approved these changes
Dec 1, 2024
…lculations-local-save # Conflicts: # app/views/calculators/show.html.erb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unknown_2024.11.29-15.51.mp4
solves #990
Code reviewers
Summary of issue
Users calculations must be saved in the storage
Summary of change
Added feature to save previous results in the session storage
CHECK LIST