Remove old React version and import React, ReactDOM and createReactCl… #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itpp-bot
reviewed
Nov 16, 2019
There was a problem hiding this comment.
├─ package-lock.json
├─ package.json
└─ ui/
├─ assets/
| ├─ excluded_files.tpl.html
| ├─ index.tpl.html
| └─ js/
| ├─ excluded_files.js
| ├─ hound.js
| └─ react-0.12.2.min.js
├─ bindata.go
├─ content.go
└─ ui.go
Installable modules remain unchanged.
Not installable modules remain unchanged.
No new features in doc/changelog.rst files of installable modules
sent by ✌️ Odoo Review Bot
…ass directly from the entry-points In this commit (af4d9a8) React and ReactDOM where added as dependencies of the project But it seems that they are not used because no entry-point import them. The React version that is used is the version 0.12.2 that is coming from 2014 and it is loaded as a separate script directly from the HTML templates. The purpose of this commit is to import React, ReactDOM, and createReactClass from the entry-points and get rid of the old react version. In this way, the project can be escalated using the new features of React
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hound-search#324