🚑 sent messages displaying issue #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itpp-bot
reviewed
Sep 30, 2019
There was a problem hiding this comment.
1 installable module is updated:
└─ mail_sent/
├─ __manifest__.py
├─ doc/
| └─ changelog.rst
└─ static/
└─ src/
└─ js/
└─ sent.js
Not installable modules remain unchanged.
sent by ✌️ Odoo Review Bot
| ------- | ||
|
|
||
| - **Imp:** Not all channel messages are shown if page was refreshed on a channel screen | ||
|
|
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| if (message) { | ||
| var current_threads = message._threadIDs; | ||
| var new_channels = data.channel_ids; | ||
| if (_.without(new_channels, ...current_threads).length) { |
There was a problem hiding this comment.
'spread/rest operator' is only available in ES6 (use 'esversion: 6').
ilmir-k
approved these changes
Oct 14, 2019
Ramil-Mukhametzyanov
approved these changes
Oct 14, 2019
yelizariev
reviewed
May 5, 2020
| } | ||
| } else if (data.author_id && data.author_id[0] && odoo.session_info.partner_id && | ||
| data.author_id[0] === odoo.session_info.partner_id) { | ||
| data.channel_ids.push('mailbox_channel_sent'); |
There was a problem hiding this comment.
Нет проверки, что сообщение имело получателя. Клиентская часть расходится с определением поля sent на сервере
yelizariev
pushed a commit
to yelizariev/mail-addons
that referenced
this pull request
Dec 2, 2021
🍒 module name change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.