fix panic: argoRolloutsEnabled=false #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nbn01 <[email protected]>
itsLucario
force-pushed
the
fix-ArgoRolloutsEnabled-false-panic
branch
from
8a0488a to
83968d9
Compare
Signed-off-by: nbn01 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we set param
ArgoRolloutsEnabled=falseRolloutController doesn’t get instantiated.But when Added/Updated function of
GlobalTrafficHandlerreceiver gets called, it in turn callsGetRolloutByLabel.And since here the controller was not instantiated and no check is done Admiral panics and crashes.
This doesn’t occur when
ArgoRolloutsEnabled=truebut when set to false admiral crashes when GlobalTrafficHandler receiver's Added/Updated function gets called.This PR does a check if
ArgoRolloutsEnabledparam is set true or false.