Fixes

itsbalamurali · Nov 12, 2023 · e391ecc · e391ecc
1 parent a1c9d96
commit e391ecc
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 0 deletions.
diff --git a/resources/compute_node.py b/resources/compute_node.py
@@ -130,6 +130,14 @@ def compute_node_deployment(
                                      "--remote-ext-config", f"{{\"bucket\":\"{extensions_bucket}\",\"region\":\"{extensions_bucket_region}\"}}",
                                      "--control-plane-uri", f"http://control-plane.{namespace}.svc.cluster.local:1234",
                                      "--compute-id", "$(COMPUTE_ID)"],
+                            readiness_probe=kubernetes.client.V1Probe(
+                                http_get=kubernetes.client.V1HTTPGetAction(
+                                    path="/status",
+                                    port=3080,
+                                ),
+                                initial_delay_seconds=5,
+                                period_seconds=5,
+                            ),
                             env=[
                                 # NOTE: Only works with kubernetes 1.28+
                                 kubernetes.client.V1EnvVar(

diff --git a/resources/pageserver.py b/resources/pageserver.py
@@ -140,6 +140,17 @@ def pageserver_statefulset(namespace: str,
                             "pageserver", "-D", "/data/.neon/", "-c", "id=$(POD_INDEX)", "-c",
                             "broker_endpoint='http://storage-broker." + namespace + ".svc.cluster.local:50051'"
                         ],
+                        readiness_probe=kubernetes.client.V1Probe(
+                            http_get=kubernetes.client.V1HTTPGetAction(
+                                path="/v1/status",
+                                port=9898,
+                            ),
+                            initial_delay_seconds=10,
+                            timeout_seconds=5,
+                            period_seconds=5,
+                            success_threshold=1,
+                            failure_threshold=3,
+                        ),
                         env=[
                             # NOTE: Only works with kubernetes 1.28+
                             kubernetes.client.V1EnvVar(

diff --git a/resources/safekeeper.py b/resources/safekeeper.py
@@ -116,6 +116,14 @@ def safekeeper_statefulset(
                         "/data",
                         f"--remote-storage={{endpoint='{remote_storage_bucket_endpoint}',bucket_name='{remote_storage_bucket_name}',bucket_region='{remote_storage_bucket_region}',prefix_in_bucket='{remote_storage_prefix_in_bucket}'}}"
                     ],
+                    readiness_probe=kubernetes.client.V1Probe(
+                        http_get=kubernetes.client.V1HTTPGetAction(
+                            path="/v1/status",
+                            port=7676,
+                        ),
+                        initial_delay_seconds=5,
+                        period_seconds=5,
+                    ),
                     env=[
                         # NOTE: Only works with kubernetes 1.28+
                         kubernetes.client.V1EnvVar(

diff --git a/resources/storage_broker.py b/resources/storage_broker.py
@@ -80,6 +80,12 @@ def storage_broker_deployment(
                     name="storage-broker",
                     image=image,
                     command=["storage_broker", "--listen-addr=0.0.0.0:50051"],
+                    readiness_probe=kubernetes.client.V1Probe(
+                        http_get=kubernetes.client.V1HTTPGetAction(
+                            path="/status",
+                            port=50051,
+                        ),
+                    ),
                     ports=[
                         kubernetes.client.V1ContainerPort(
                             container_port=50051,