No unique resource #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This update has now been rebased on the revert to v.1.03. |
msdemlei
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
I'm fine with the intent and the form of this change.
Github right now considers this a 9 commit-PR. I have not tried to figure out what confuses the history it sees, but I'd be confident that nothing bad will happen if you squash and merge. If, on the other hand, you insist on a merge commit, I'd first try what happens locally...
|
(and if you give me write privileges, I expect the merge block should be lifted, too) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request builds on the revert to v.1.03.
It must not be merged before #55 is merged, or reconsidered if it gets discarded.
It only relaxes the text for uniqueness of the RESOURCE(s) in the VOTable response