DateFilter based on the wagtail-datepicker #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a DateFilter using Wagtail's datepicker implementation.
Backend code
Backend code works like the django/wagtail form fields and widgets. Its uses mostly the same code to parse and output dates from strings and vice versa.
Beware:
date-time-chooser.jsis always injected intomediaof the view, but I didn't saw any harm in doing that.Frontend code
Frontend is a bit messy (see:
useEffecthook incomponents/filters/date.js), because there seems to be an error in wagtail'sonGeneratefunction. It breaks with a custom date format. I replicated the functionality and it seems to works fine. But you never know ... Ye old ~3000 linejquery.datetimepicker.jsis a bit intimidating :)