-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple VLP-16 LiDAR to Husky Pipeline #28
Open
Assume-Zhan
wants to merge
19
commits into
j3soon:main
Choose a base branch
from
Assume-Zhan:vlp_to_husky_ws
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With remove unused files
Refer to this commit: j3soon@cd37898 With consideration to become submodule.
Refer to this branch: https://github.com/Assume-Zhan/ros2-agv-essentials/tree/velodyne-lidar I've only copy the simulator package since we only need add the LiDAR on the husky.
- Set parent to `top_plate_link` which is a plate on top of the husky
It seems that the package URL description before is not working since we didn't set the model config in velodyne_description. Instead of setting model config, I think it is faster if we directly change to find command
Follow by the script ./create_workspace.sh
- Also remove unused cpp file
Ref: https://github.com/YuZhong-Chen/ros2-agv-essentials/blob/0641a64f0fa454421134e45f6005d9940facf008 File path: zed_to_husky_ws/workspaces/dummy_controller_ws/src/dummy_controller/dummy_controller/publisher.py
Ref: https://github.com/YuZhong-Chen/ros2-agv-essentials/blob/0641a64f0fa454421134e45f6005d9940facf008 File path: zed_to_husky_ws/workspaces/dummy_controller_ws/src/dummy_controller/scripts/main.py
- Only when there is something in front of 2.5 range it will stop
- husky_ws - dummy_controller_ws - vlplidar_ws
- Reuse the Dockerfile in previous three workspaces - Build the workspaces
- For husky_ws, we may need further script to run the real husky, I only run bash when create the container. - For vlplidar_ws, it could directly run the launch file and remove the is_sim flag.
j3soon
force-pushed
the
main
branch
2 times, most recently
from
October 23, 2024 19:17
a8b1110
to
dbd12e4
Compare
j3soon
force-pushed
the
main
branch
5 times, most recently
from
December 13, 2024 16:12
ffd229a
to
c709a39
Compare
j3soon
force-pushed
the
main
branch
2 times, most recently
from
December 15, 2024 03:53
ecf7008
to
adf7444
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to PR #27 but with LiDAR to husky