[@sigma/node-image] Add crossOrigin to TextureManagerOptions #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacomyal
added a commit
that referenced
this pull request
Jul 2, 2024
Details: - Allows crossOrigin to be `null`, as the comment says it could - When `null`, then no "crossOrigin" attribute is set (as specified in the same comment) - Runs prettify
|
I manually rebased and merged this PR, and GitHub didn't catch it. So, I'll close it manually. Thanks for your contribution! It is deployed in @sigma/[email protected]. |
This was referenced Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Check the type of change your PR introduces:
What is the current behavior?
Currently Sigma harcode the cross origin policy of the images rendered by node-image. Because of that it is currently impossible to fetch images that require authentification. I personally had to completly fork the node-image package just to change that one hardcoded attribute.
Issue Number: #1403
Related PR: #1393
What is the new behavior?
A
crossOriginattribute has been added to theTextureManagerOptions. This attribute is then passed to the functions that load images to set the crossOrigin attribute.Other information
Another PR (#1393 ) is opened for the same feature but it's quite old and precede the creation of the TextureManagerOptions