Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Own dot graphics draft, multiline labels fix #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IvoryTowerDSPWizard
Copy link

Hi there! Thanks for the library :)
This PR is just an idea. I had to add some functionality.
Here each dot can have own draw function. It could also process mouseOver events there (I didn't add that). And it could have own predicate to define if a dot should be shown.

image

@IvoryTowerDSPWizard
Copy link
Author

IvoryTowerDSPWizard commented Jun 4, 2020

A couple of other things that could be improved.

  • Not updating the plot canvas when no zoom/pan change occured
  • Perhaps some data compression would be nice too - I added it in my client wrapper code to handle 700k+ data points. Each graph has several compression levels so that only a limited amount of objects is shown. Instead of N separate points you draw a rectangle with sizes that correspond to min and max values in that N range. That takes <2x the memory but exponentially increases the speed.
    image
    image

@IvoryTowerDSPWizard
Copy link
Author

unfortunately I don't have the time to do a proper refactoring and PRs but I can provide my wrapper code so that you'd use the data compression logic that I've written

@jagracar
Copy link
Owner

jagracar commented Jun 8, 2020

Thank you for the PR! I'm quite busy at the moment, but I will check the code when I have some time and will integrate those parts that fit well. Thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants